Repository navigation
feat(resolver): let hook profiles work with only a download hook - #1409
Merged
LalatenduMohanty merged 1 commit intoOct 28, 2026
Conversation
LalatenduMohanty
marked this pull request as ready for review
October 28, 2026 18:38
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
LalatenduMohanty
force-pushed
the
issue-1387-hook-standard-resolution
branch
3 times, most recently
from
October 28, 2026 19:05
e7fd954 to
5dac270
Compare
If a package has a download hook but no resolver hook, `hook-sdist` and `hook-prebuilt` now find versions on their `index_url`. A package with no hooks gets an error. Closes: python-wheel-build#1387 Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
force-pushed
the
issue-1387-hook-standard-resolution
branch
from
October 28, 2026 21:03
5dac270 to
fb7b165
Compare
smoparth
approved these changes
Oct 28, 2026
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
LalatenduMohanty
merged commit Oct 28, 2026
2cecb06
into
python-wheel-build:new-resolver-config
66 of 69 checks passed
This was referenced Oct 28, 2026
LalatenduMohanty
added a commit
that referenced
this pull request
Oct 30, 2026
0.102.0 was released from `main` without the new resolver config, so the feature branch's version notes must name the next release. - Change every `versionadded` and `versionchanged` added on this branch (0.95.0, 0.96.0 and 0.102.0) to 0.103.0. - Merge notes that now sit next to each other with the same version. - Drop the stale "do not fall back to PyPI" sentence for hook profiles. Since #1409, a hook profile without a `get_resolver_provider` hook finds versions on its `index_url`. Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a package has a
download_sourcehook but noget_resolver_providerhook,hook-sdistandhook-prebuiltnow find versions on theirindex_url:hook-sdistlooks at sdists and wheels for any platform, likepypi-git.hook-prebuiltlooks at wheels for this platform, likepypi-prebuilt.The download hook then gets the source or wheel. A package with neither hook gets an error that suggests
pypi-sdistorpypi-prebuilt. Packages with a resolver hook work as before.This follows the decision in #1387 (comment).
Closes: #1387
🤖 Generated with Claude Code